SDL/src
Sam Lantinga 0694baf260 Fixed bug 2736 - X11 doesn't set KMOD_NUM and KMOD_CAPS to system state
Zack Middleton

Using X11 (on Debian Wheezy), SDL_GetModState() & KMOD_NUM and KMOD_CAPS are not set to system state (numlock/capslock LEDs). Pressing numlock or capslock toggles the mod state, though if num/caps lock is enabled before starting the program it's still reversed from system state. This makes getting KMOD_NUM and KMOD_CAPS in programs unreliable. This can be seen using the checkkeys test program.

The function that appears to have handle this in SDL 1.2 is X11_SetKeyboardState. The function call is commented out with "FIXME:" in SDL 2.

Using Windows backend through WINE; on first key press if numlock and/or capslock is enabled on system, numlock/capslock SDL_SendKeyboardKey is run and toggles KMOD_NUM/KMOD_CAPS to the correct state. On X11 this does not happen.

The attached patch makes X11 backend set keyboard state on window focus if no window was previously focused. It sets all keys to system up/down state and toggles KMOD_NUM/KMOD_CAPS via SDL_SendKeyboardKey to match system if needed. The patch is based on SDL 1.2's X11_SetKeyboardState.
2015-05-28 09:33:47 -07:00
..
atomic Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
audio Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
core [IBus] Only register interest in messages sent to our input context. 2015-02-27 21:17:29 +00:00
cpuinfo Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
dynapi Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
events Added some unknown keys from Japanese 106/109 keyboards (thanks, "ver0hiro"!). 2015-05-26 20:55:03 -04:00
file Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
filesystem Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
haptic I think this will be the time... 2015-05-28 01:27:24 -04:00
joystick Another attempt to get this to compile. 2015-05-28 01:08:33 -04:00
libm Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
loadso Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
main Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
power Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
render Drop out of SDL_UpdateTexture() early if the rectangle is zero pixels. 2015-05-26 16:42:36 -04:00
stdlib Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
test Some setups need _GNU_SOURCE to make LLONG_MAX available (thanks, Ozkan!). 2015-05-26 16:31:11 -04:00
thread Uh, yeah, it helps to press "Save" before committing... 2015-05-26 21:30:41 -04:00
timer Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
video Fixed bug 2736 - X11 doesn't set KMOD_NUM and KMOD_CAPS to system state 2015-05-28 09:33:47 -07:00
SDL.c Stack hint should look for 0, not -1, and not care about environment variables. 2015-05-26 21:19:23 -04:00
SDL_assert.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_assert_c.h Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_error.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_error_c.h Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_hints.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_internal.h Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_log.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00