BramReuling/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-06-26 15:58:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix SDL GPU D3D12 Descriptor Heap leak

Browse source 
When descriptor leaks overflow, the D3D12 SDL GPU renderer fetches more from the pool, but never returns them, which eventually causes an "out of memory" crash.
This commit is contained in:
Edu Garcia 2025-10-09 14:43:11 +01:00 • committed by Sam Lantinga
parent 2a96997e90
commit c74b406a4c
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/gpu/d3d12/SDL_gpu_d3d12.c
View file

@ -4885,7 +4885,14 @@ static void D3D12_INTERNAL_SetGPUDescriptorHeaps(D3D12CommandBuffer *commandBuff
viewHeap = D3D12_INTERNAL_AcquireGPUDescriptorHeapFromPool(commandBuffer, D3D12_DESCRIPTOR_HEAP_TYPE_CBV_SRV_UAV);
samplerHeap = D3D12_INTERNAL_AcquireGPUDescriptorHeapFromPool(commandBuffer, D3D12_DESCRIPTOR_HEAP_TYPE_SAMPLER);
if (commandBuffer->gpuDescriptorHeaps[0] != NULL) {
D3D12_INTERNAL_ReturnGPUDescriptorHeapToPool(commandBuffer->renderer, commandBuffer->gpuDescriptorHeaps[0]);
}
commandBuffer->gpuDescriptorHeaps[0] = viewHeap;
if (commandBuffer->gpuDescriptorHeaps[1] != NULL) {
D3D12_INTERNAL_ReturnGPUDescriptorHeapToPool(commandBuffer->renderer, commandBuffer->gpuDescriptorHeaps[1]);
}
commandBuffer->gpuDescriptorHeaps[1] = samplerHeap;
heaps[0] = viewHeap->handle;