BramReuling/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-06-26 15:58:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Don't do NULL-checks before free()

Browse source
This commit is contained in:
Eddy Jansson 2025-10-19 11:17:11 +02:00 • committed by Sam Lantinga
parent aaee09d6ed
commit 3b0347ac48
3 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/dialog/windows/SDL_windowsdialog.c
View file

@ -731,7 +731,9 @@ quit:
// default_file_w is a pointer into default_folder_w.
if (default_folder_w) {
SDL_free(default_folder_w);
} else SDL_free(default_file_w);
} else {
SDL_free(default_file_w);
}
SDL_free(title_w);

4
src/hidapi/windows/hid.c
View file

@ -991,9 +991,7 @@ struct hid_device_info HID_API_EXPORT * HID_API_CALL hid_enumerate(unsigned shor
break;
}
if (device_interface_list != NULL) {
free(device_interface_list);
}
free(device_interface_list); // This should NOT be SDL_free()
device_interface_list = (wchar_t*)calloc(len, sizeof(wchar_t));
if (device_interface_list == NULL) {

11
src/video/x11/xsettings-client.c
View file

@ -659,9 +659,8 @@ xsettings_setting_copy (XSettingsSetting *setting)
return result;
err:
if (result->name)
free (result->name);
free (result);
free(result->name); // This should NOT be SDL_free()
free(result); // This should NOT be SDL_free()
return NULL;
}
@ -741,10 +740,8 @@ xsettings_setting_free (XSettingsSetting *setting)
if (setting->type == XSETTINGS_TYPE_STRING)
free (setting->data.v_string);
if (setting->name)
free (setting->name);
free (setting);
free(setting->name); // This should NOT be SDL_free()
free(setting); // This should NOT be SDL_free()
}
void